Skip to content

chore(jetbrains): bump commonmark to 0.30.1 - #15538

Merged
WebReflection merged 3 commits into
mainfrom
chore/jetbrains-commonmark-0.30.1
Oct 28, 2026
Merged

WebReflection merged 3 commits into
mainfrom
chore/jetbrains-commonmark-0.30.1

Conversation

@WebReflection

@WebReflection WebReflection commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Bumps org.commonmark (core plus the autolink, gfm-tables and gfm-strikethrough extensions) from 0.30.0 to 0.30.1 in the JetBrains plugin.

0.30.1 fixes a code-span parsing regression introduced in 0.30.0 (commonmark/commonmark-java#459) and speeds up MarkdownRenderer (commonmark/commonmark-java#456).

This splits the commonmark update out of #15421. That Dependabot group also bumps Kotlin to 2.4.21, which breaks :shared:compileKotlin: the IntelliJ RPC compiler plugin (2.3.21-RC2-0.1) only supports Kotlin 2.3, and no RPC plugin build exists for Kotlin 2.4.21 yet. The Kotlin bump has to wait for a matching RPC plugin release.

It also fixes a flaky backend test, WorktreeTrashTest > repeated sweeps and reaps do not accumulate jobs, which failed CI on this PR with expected: <0> but was: <1>. A finished job stops being isActive before the completion handler that removes it from jobs runs, so the test-only drain() could return while pending() still counted that job. drain() now also waits for those handlers. Only test helpers changed; production code paths are unaffected.

@WebReflection WebReflection added the dependencies Pull requests that update a dependency file label Oct 28, 2026
@github-actions github-actions Bot added the area:jetbrains JetBrains plugin label Oct 28, 2026
@socket-security

socket-security Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

@kilo-code-bot

kilo-code-bot Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

The WorktreeTrash.drain() change is a test-only helper and correctly closes the race where a finished job is no longer isActive but has not yet been removed from jobs by its completion handler; the loop keeps yielding until jobs empties, so it cannot return early while pending() still counts a completed job. The commonmark bump keeps all four extension modules on the same version.ref, so no version skew.

Files Reviewed (2 files)
  • packages/kilo-jetbrains/gradle/libs.versions.toml
  • packages/kilo-jetbrains/backend/src/main/kotlin/ai/kilocode/backend/worktree/WorktreeTrash.kt
Previous Review Summary (commit 246ec0c)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 246ec0c)

Status: No Issues Found | Recommendation: Merge

lgtm

Files Reviewed (1 file)
  • packages/kilo-jetbrains/gradle/libs.versions.toml

Reviewed by deepseek-flash-latest · Input: 33.9K · Output: 4.9K · Cached: 277.5K

Review guidance: REVIEW.md from base branch main

@WebReflection
WebReflection merged commit 722e465 into main Oct 28, 2026
25 checks passed
@WebReflection
WebReflection deleted the chore/jetbrains-commonmark-0.30.1 branch October 28, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:jetbrains JetBrains plugin dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants