Conversation
tests/fuzz is a CMake project of its own that adds lib/ as a sub-project, like tests/use-ktx, and builds ktx_read with Clang, libFuzzer instrumentation and ASan + UBSan. ktx_read_fuzzer loads each input as an application loads an untrusted file: create the texture, load the image data, transcode Basis Universal data and read all of it. Headers declaring more than 64 MiB of data are skipped before the data is loaded. The new Fuzz job in linux.yml builds it, fuzzes for 10 minutes from the small KTX and KTX2 files in tests/resources and uploads any finding. It is separate from the ASan job because libFuzzer needs Clang and its own instrumented build.
Collaborator
|
Thank you for this. I am sick right now. I will review when I feel better. I am not enabling the workflows in this because, due to a recent change in the windows-11-arm runner that job will fail. I have a fix in progress but it is delayed due to my sickness and it having a crash in the mingw workflow that I am unable to reproduce locally. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests/fuzz is a CMake project of its own that adds lib/ as a sub-project, like tests/use-ktx, and builds ktx_read with Clang, libFuzzer instrumentation and ASan + UBSan. ktx_read_fuzzer loads each input as an application loads an untrusted file: create the texture, load the image data, transcode Basis Universal data and read all of it. Headers declaring more than 64 MiB of data are skipped before the data is loaded.
The new Fuzz job in linux.yml builds it, fuzzes for 10 minutes from the small KTX and KTX2 files in tests/resources and uploads any finding. It is separate from the ASan job because libFuzzer needs Clang and its own instrumented build.
On main the test fails within a second. The generic
ktxTexture_CreateFromMemoryleaks its memory stream for any input that is not a KTX file (#1260), and fuzzing produces those constantly. With leak detection off, the next report is the ETC1S decode issue (#1254).actions/cache, or ClusterFuzzLite's batch mode) would find deeper bugs than a fresh 10-minute run per PR.