markdown-preview: quit app before uninstall - #288728
Merged
krehel merged 2 commits intoSep 22, 2026
Merged
Conversation
mfauzaan
force-pushed
the
markdown-preview-quit-on-uninstall
branch
from
September 22, 2026 07:55
f4bdb2a to
11cb042
Compare
krehel
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quit Markdown Preview before removing the app. Otherwise, a running copy survives uninstall/reinstall, and opening the replacement just activates the old process. Its Quick Look extension stays unregistered until the app is fully quit and launched again.
Tested on macOS 26.6.2 with the patched cask installed: both uninstall/install and reinstall quit the old process, and a fresh launch registered the replacement extension. Existing installations can still use their previously saved uninstall instructions on the first reinstall.
Related: pluk-inc/markdown-preview#413
After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>is error-free.brew style --fix <cask>reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new <cask>worked successfully.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask>worked successfully.brew uninstall --cask <cask>worked successfully.zapstanza paths; I did not attribute commits to AI and will answer maintainer questions and review comments myself without AI/LLM.Codex (GPT-6) made the cask edit and ran the local install/uninstall tests, process and extension-registration checks, audit, and style check. The
zapstanza is unchanged. The personal-review checkbox is left for the contributor to complete.