Skip to content

markdown-preview: quit app before uninstall - #288728

Merged
krehel merged 2 commits into
Homebrew:mainfrom
mfauzaan:markdown-preview-quit-on-uninstall
Sep 22, 2026
Merged

krehel merged 2 commits into
Homebrew:mainfrom
mfauzaan:markdown-preview-quit-on-uninstall

Conversation

@mfauzaan

@mfauzaan mfauzaan commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Quit Markdown Preview before removing the app. Otherwise, a running copy survives uninstall/reinstall, and opening the replacement just activates the old process. Its Quick Look extension stays unregistered until the app is fully quit and launched again.

Tested on macOS 26.6.2 with the patched cask installed: both uninstall/install and reinstall quit the old process, and a fresh launch registered the replacement extension. Existing installations can still use their previously saved uninstall instructions on the first reinstall.

Related: pluk-inc/markdown-preview#413


After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

  • I did not use AI/LLM to create this PR, or I disclosed the tool/model below and reviewed its output, including zap stanza paths; I did not attribute commits to AI and will answer maintainer questions and review comments myself without AI/LLM.

Codex (GPT-6) made the cask edit and ran the local install/uninstall tests, process and extension-registration checks, audit, and style check. The zap stanza is unchanged. The personal-review checkbox is left for the contributor to complete.

@github-actions github-actions Bot closed this Sep 21, 2026
@github-actions github-actions Bot reopened this Sep 21, 2026
@mfauzaan
mfauzaan force-pushed the markdown-preview-quit-on-uninstall branch from f4bdb2a to 11cb042 Compare September 22, 2026 07:55
@krehel
krehel added this pull request to the merge queue Sep 22, 2026
Merged via the queue into Homebrew:main with commit 7b6d4b0 Sep 22, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants