Repository navigation
Use apt::keyring instead of global trusted.gpg.d - #84
Open
fabianspannagel wants to merge 1 commit into
Open
fabianspannagel wants to merge 1 commit into
fabianspannagel wants to merge 1 commit into
Conversation
Install the Graylog repository key via apt::keyring and reference it with signed-by instead of trusting it globally. Remove the legacy /etc/apt/trusted.gpg.d/graylog-keyring.gpg. Requires puppetlabs/apt >= 9.2.0.
Author
|
@bernd , could you take a look at this when you have time? It moves the Graylog apt key to /etc/apt/keyrings with signed-by and raises the puppetlabs/apt minimum to 9.2.0. Unit tests and an Ubuntu 22.04 acceptance run are described above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Installs the Graylog repo key with
apt::keyringand references it viasigned-by(/etc/apt/keyrings/graylog-keyring.gpg) instead of writing it to the global/etc/apt/trusted.gpg.d/. The legacy key file is removed.Breaking change
puppetlabs/aptminimum is now 9.2.0, the first release withapt::keyring.trusted.gpg.d.Testing
pdk validate: no new warningspdk test unit(repository_spec.rb): passes, spec updated for the new resourcesoperatingsystem_supportbut were only compile-tested via unit testsNotes
server_spec.rbhas 14 failures onmaintoo (Sensitiveserver.confcontent with Puppet 8), unrelated to this change.