Repository navigation
Add mode selector - #751
Merged
thestinger merged 1 commit intoOct 4, 2026
Merged
thestinger merged 1 commit into
thestinger merged 1 commit into
Conversation
m4pl
force-pushed
the
task/736-mode-selector-composable
branch
2 times, most recently
from
October 3, 2026 13:29
3b93575 to
fcc898a
Compare
m4pl
marked this pull request as ready for review
October 3, 2026 13:29
m4pl
force-pushed
the
task/736-mode-selector-composable
branch
from
October 4, 2026 20:51
fcc898a to
e245a5a
Compare
RankoR
approved these changes
Oct 4, 2026
sdsantos
approved these changes
Oct 5, 2026
| columnIndex = index, | ||
| columnSpan = 1, | ||
| ) | ||
| this.customActions = customActions |
There was a problem hiding this comment.
I'm not familiar with accessibility in Tabs. But it feels a bit weird that each individual tab has custom actions to select all other tabs except the focused tab, including the already selected tab. I know that the main action selects it.
I would expect either:
a) Just custom actions on the TabGroup level, that would let me select an individual tab.
b) That individual tab custom actions include the tab itself if it's not selected, and not include the already selected tab.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can check it here - ModeSelectorSample.kt
Closes #736