Repository navigation
revert(storage): remove delete object contexts sample (#2342) - #2358
Open
sahusneha2004 wants to merge 1 commit into
Open
sahusneha2004 wants to merge 1 commit into
sahusneha2004 wants to merge 1 commit into
Conversation
|
Here is the summary of changes. You are about to delete 1 region tag.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Code Review
This pull request removes the delete_object_contexts sample file and updates the test suite in storage/test/ObjectsTest.php to clear object contexts inline using the $object->update() method directly. There are no review comments to address, and the changes look correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #2342 (
feat(storage): add delete object contexts sample), which was created and merged accidentally.Changes:
storage/src/delete_object_contexts.php(region tagstorage_delete_object_contexts).storage/test/ObjectsTest.php::testObjectContextsto its state before feat(storage): add delete object contexts sample #2342.Note: #2353 later made a one-line tweak to
delete_object_contexts.php(?? nullon the metageneration precondition). Since the file is removed, that tweak goes too. No other files from #2353 are affected.