Skip to content

revert(storage): remove delete object contexts sample (#2342) - #2358

Open
sahusneha2004 wants to merge 1 commit into
mainfrom
revert-delete-object-contexts-2342
Open

sahusneha2004 wants to merge 1 commit into
mainfrom
revert-delete-object-contexts-2342

Conversation

@sahusneha2004

Copy link
Copy Markdown
Contributor

Reverts #2342 (feat(storage): add delete object contexts sample), which was created and merged accidentally.

Changes:

Note: #2353 later made a one-line tweak to delete_object_contexts.php (?? null on the metageneration precondition). Since the file is removed, that tweak goes too. No other files from #2353 are affected.

This reverts commit a4823a4.

PR #2342 was created and merged accidentally. Also drops the follow-up
one-line tweak to this file from #2353.
@sahusneha2004
sahusneha2004 requested review from a team as code owners November 9, 2026 15:24
@snippet-bot

snippet-bot Bot commented Nov 9, 2026

Copy link
Copy Markdown

Here is the summary of changes.

You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label Bot added api: storage Issues related to the Cloud Storage API. samples Issues that are directly related to samples. labels Nov 9, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the delete_object_contexts sample file and updates the test suite in storage/test/ObjectsTest.php to clear object contexts inline using the $object->update() method directly. There are no review comments to address, and the changes look correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant