Repository navigation
Fix ICN001 (unconventional-import-alias) violations in ruff v0.17.0 - #4946
Merged
Merged
Conversation
yvonnefroehlich
approved these changes
Oct 10, 2026
yvonnefroehlich
left a comment
Member
There was a problem hiding this comment.
OK with following the rule.
But I believe this can cause confusion by overwriting it accidentally when using dt as a variable name for a time difference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ruff v0.17.0 introduces a breaking change to the rule
ICN001(unconventional-import-alias), resulting failures in the Style Checks workflow (https://github.com/GenericMappingTools/pygmt/actions/runs/38022301186/job/114125705838)with errors like:
ruff v0.17.0 recommends
import datetime as dt, rather thanimport datetime, following the Python official documentation at https://docs.python.org/3.13/library/datetime.html#datetime.timedelta.This PR fixes the violations. The changes are automatically done by running
ruff check --fix --unsafe-fixes.The new codes still works with old ruff versions, so no ruff version bump here.