Repository navigation
fix: Use env from codechecker_config in per-file - #340
Merged
Merged
Conversation
furtib
changed the title
furtib
added
bug
Szelethus
reviewed
Oct 6, 2026
furtib
force-pushed
the
per-file-fix-env
branch
from
October 6, 2026 09:23
de9f739 to
af25904
Compare
Szelethus
reviewed
Oct 6, 2026
Szelethus
approved these changes
Oct 6, 2026
Collaborator
There was a problem hiding this comment.
I will have to admit that the new prepended env vars are an ugly beast on top of the CodeChecker call. Then again, everything we do here is in the name of being holistic and all encompassing... In that case, function should prevail over form at any costs.
Besides, these are logs. They are meant to be information-first.
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
When
use_default_shell_env=Truewas used in the per_file rule, we purposefully didn't use env vars from the codechecker_config target. We have since removeduse_default_shell_env=True, so we should use these environment variables.What:
Addresses:
Fixes: #341