Repository navigation
Conversation
barnabasdomozi
requested changes
Oct 5, 2026
barnabasdomozi
left a comment
barnabasdomozi
left a comment
Collaborator
There was a problem hiding this comment.
Currently, the linter tests are failing:
https://github.com/Ericsson/codechecker/actions/runs/36990197079/job/110784360627?pr=5122
Also, sorry for changing things around but I think it would make more sense to have two PRs instead:
- one for database related changes, including Alembic migration
- one for Thrift API changes, with server side implementation complete
This way, we can merge the changes to master.
So for this PR, only keep changes made to file web/server/codechecker_server/database/run_db_model.py and also implement the Alembic migration (guide here: https://github.com/Ericsson/codechecker/blob/master/docs/web/db_schema_guide.md).
Thanks!
| primary_key=True | ||
| ) | ||
|
|
||
| def __init__(self, run_id, run_label_id): |
Collaborator
There was a problem hiding this comment.
Please add type annotations for function parameters.
| label_name = Column(String, nullable=False, unique=True, index=True) | ||
| description = Column(String, nullable=True) | ||
|
|
||
| def __init__(self, label_name, description=None): |
Collaborator
There was a problem hiding this comment.
Please add type annotations for function parameters.
sproderj
marked this pull request as draft
October 6, 2026 07:54
sproderj
marked this pull request as ready for review
October 8, 2026 12:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding run_labels and run_to_run_labels for db and run label related API calls