Repository navigation
.NET code no longer compiles after PR merge. #903
Description
#893 was merged into main however it appears something went wrong and the code in main no longer compiles.
develop branch also no longer compiles with different exception than main.
PR origin https://github.com/softworkz/ElectronNET/tree/electronnet_core works perfectly fine.
Activity
FlorianRappl commentedon Nov 4, 2025
Yes, the
Processclass has been updated and brought back. It was one of the classes missing in the referenced origin.agracio commentedon Nov 4, 2025
@FlorianRappl not sure why you closed it as completed, current code in main does not compile. Is there a pending PR to fix it?
I performed fresh checkouts on both
mainanddevelopbranches just in case there were some merge issues.FlorianRappl commentedon Nov 4, 2025
mainis the release branch. There is no release for the 0.1.0 yet. Right now its a preview.developworks - if in doubt look at the actionIn general build failures are not for the issue tracker (esp. labelled as "bugs", which are issues with the lib - a build failure does not trigger a build). So a bit odd to open a bug for it - but at least it acted as a reminder.
agracio commentedon Nov 4, 2025
develop- it was failing when I opened this issue.Yes a 'bug' might have been a mistake but as for issue tracker it does make sense to open an issue if there is a problem with the code. Thank you for taking care of the compile error.
FlorianRappl commentedon Nov 4, 2025
Yes I know. But when I closed it the build was running again. (2) was a response to your last comment, not the OP.
agracio commentedon Nov 4, 2025
What is the current status of
developbranch, I mentioned in another issue that the code can benefit from refactoring shaving 1.5k-2k lines of code, but do not want to make changes while the branch is still unstable should I wait for a merge to main first?FlorianRappl commentedon Nov 4, 2025
You can always make a PR.
Target for any PRs should be
develop.agracio commentedon Nov 4, 2025
Unfortunately
developbranch is still broken. Both test projects ElectronNET.ConsoleApp and ElectronNET.WenApp have incorrect nuget dependencies.This results in solution build errors and inability to launch local test app.
I was able to resolve issue locally by updating ElectronNET.Core and ElectronNET.Core.AspNet nuget package references to 0.0.18.
PR #904
FlorianRappl commentedon Nov 4, 2025
Nope - they are set to what
mainwill be. For these projects you should always either change locally or usemain.