[phcorp]

Problem

ea_as_string shows an object that is neither translatable nor Stringable as <class> #<id>, and reads the id only through getId(). An entity can expose its id as a public property instead and have no getId() at all, for example with PHP 8.4 asymmetric visibility:

#[ORM\Entity]
class Book
{
    #[ORM\Id, ORM\GeneratedValue, ORM\Column]
    public private(set) ?int $id = null;
}

Such an entity is shown with an object hash that changes on every request, e.g. in the headers of CollectionField entries.

Also, when getId() returns something that can't be cast to a string (an array, or an object that isn't Stringable), the filter fails with "Object of class X could not be converted to string". When it returns null, it shows <class> #.

Fix

The id is read from getId(), or else from a public, initialized $id property (property hooks included). The object hash is still the fallback when there's no id, or when the id is null, an array or a non-Stringable object.

Tests

New cases in the ea_as_string data provider of tests/Unit/Twig/EasyAdminTwigExtensionTest.php:

• a public $id property: an int, and a Stringable object
• a private $id property: falls back to the hash
• getId() returning null, and getId() returning a non-Stringable object: both fall back to the hash

Results:

• make tests ARGS="tests/Unit/Twig": OK (287 tests)
• make tests-parallel: OK (3691 tests)
• phpstan and php-cs-fixer: no errors

[javiereguiluz]

Thanks @phcorp.