Repository navigation
fix(webhooks): skip GitHub push events that delete a branch or tag - #5954
Open
AryaKesharwani wants to merge 1 commit into
Open
AryaKesharwani wants to merge 1 commit into
AryaKesharwani wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR about?
Deleting a branch or tag on GitHub sends a
pushwebhook with"deleted": true(andafterset to all zeros).pages/api/deploy/github.tsdoesn't check for it, so:shouldDeployreturnstruewhen no watch paths are set), and the deploy then fails because the branch no longer exists;Tag created: <tag>for apps that deploy on tags, which fails the same way.The handler now answers
200with "Deployment skipped: ref was deleted" for push events wheredeletedis true, before the tag and branch handling.Checklist
Before submitting this PR, please make sure that:
canarybranch.Issues related (if applicable)
None open for this case.
Screenshots (if applicable)
Added
ignores push events that delete a branchto__test__/deploy/github-webhook-handler.test.ts. It fails oncanary(a deploy is queued) and passes with the fix; the file passes 9/9.

Confidence Score: 5/5
The PR appears safe to merge.Summary
Skips GitHub push events that delete a branch or tag.
Reviews (1) · Last reviewed commit: "fix(webhooks): skip GitHub push events t..." · Reviewed by Greptile