Repository navigation
Conversation
The backup file list is only fetched once a destination is set, so the search dropdown opened with nothing to show. Disable it in the database and volume restore dialogs until a destination is chosen. Refs Dokploy#5892
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR about?
In the restore dialogs, the backup file search can be opened before a destination is selected. Without a destination there is nothing to search, so the dropdown shows no useful result.
This PR disables the file search button until a destination is selected (
disabled={!destinationId}), in both restore dialogs:apps/dokploy/components/dashboard/database/backups/restore-backup.tsxapps/dokploy/components/dashboard/application/volume-backups/restore-volume-backups.tsxChecklist
canarybranch.Tests
pnpm typecheckand Biome pass.Issues related (if applicable)
Closes #5892
Screenshots (if applicable)