Skip to content

Add Neon Object Storage to destination constants - #5562

Closed
rishi-raj-jain wants to merge 1 commit into
Dokploy:canaryfrom
rishi-raj-jain:patch-1
Closed

rishi-raj-jain wants to merge 1 commit into
Dokploy:canaryfrom
rishi-raj-jain:patch-1

Conversation

@rishi-raj-jain

@rishi-raj-jain rishi-raj-jain commented Oct 1, 2026 •

Copy link
Copy Markdown

What is this PR about?

Adds Neon Object Storage to one of the S3 destinations.

Disclaimer: I work as a contractor for Neon.

Checklist

Before submitting this PR, please make sure that:

  • You created a dedicated branch based on the canary branch.
  • You have read the suggestions in the CONTRIBUTING.md file https://github.com/Dokploy/dokploy/blob/canary/CONTRIBUTING.md#pull-request
  • You have tested this PR in your local instance. If you have not tested it yet, please do so before submitting. This helps avoid wasting maintainers' time reviewing code that has not been verified by you.

Issues related (if applicable)

Screenshots (if applicable)

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge, with the existing non-blocking concern about rclone receiving `Neon` unchanged.

Summary

Adds Neon Object Storage to the destination dropdown.

  • Users can choose Neon Object Storage for an S3 destination.

Reviews (2) · Last reviewed commit: "Add Neon Object Storage to destination c..." · Reviewed by Greptile

name: "Minio Object Storage",
},
{
key: "Neon",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Neon choice uses generic settings

Selecting Neon Object Storage sends Neon to rclone as --s3-provider=Neon. Rclone does not recognize that provider name, so it warns and uses generic S3 settings instead. Map this choice to Other until rclone supports Neon, so the saved setting matches what users get.

Knowledge Base Used: Backups and restore

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@greptile review

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No actionable findings. The earlier concern is overstated: rclone added Neon as a provider in v1.76.0. Older versions fall back to the generic Other provider with a warning, rather than failing, and Dokploy already passes --s3-force-path-style, which Neon requires. The added dropdown entry is therefore compatible with both current and older rclone versions.

Tip: You can customize Greptile's behavior for this repo with .greptile/rules.md and .greptile/config.json.

@rishi-raj-jain

Copy link
Copy Markdown
Author

I see, I'll re open it once https://github.com/rclone/rclone/pull/10007/changes is merged.

@rishi-raj-jain

Copy link
Copy Markdown
Author

Neon is now a first party integration in rclone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant