Skip to content

[COMPAT] Require Python 3.12 - #507

Merged
Jokeren merged 1 commit into
mainfrom
compat/require-python-3.12
Oct 14, 2026
Merged

[COMPAT] Require Python 3.12#507
Jokeren merged 1 commit into
mainfrom
compat/require-python-3.12

Conversation

@mark14wu

@mark14wu mark14wu commented Oct 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Changes

  • pyproject.toml:
    • requires-python goes from >=3.10 to >=3.12.
    • The cp310/cp311 neuronx-cc and nki wheel sources are removed.
  • README.md and AGENTS.md: the minimum Python becomes 3.12.

Why

#494 finds the traced helpers a kernel calls by reading the kernel's co_names. That list includes the names called inside comprehensions only from Python 3.12 on (PEP 709).

@mark14wu
[COMPAT] Require Python 3.12
e20cc79 
CI and the publish workflow already run only 3.12, and building from
source already needs 3.11 (setup.py imports tomllib). README and
AGENTS.md follow, and the cp310/cp311 NKI wheel sources go.
@github-actions

github-actions Bot commented Oct 14, 2026 •
edited
Loading

Copy link
Copy Markdown

Performance Benchmark

Benchmark main (min) PR (min) Change Samples
gemm 0.105s 0.105s +0.3% 20 / 20
gemm_oob 0.118s 0.117s -0.6% 20 / 20
indirect_load 0.022s 0.022s -0.6% 20 / 20
nested_loop 0.235s 0.237s +1.0% 20 / 20
block_pointer_loop_advance 0.126s 0.126s +0.3% 20 / 20
liger_jsd 0.139s 0.139s -0.3% 20 / 20
flaggems_layernorm 0.393s 0.392s -0.3% 20 / 20
swiglu 0.171s 0.171s -0.1% 20 / 20
cross_entropy 0.975s 0.979s +0.4% 20 / 20
fused_linear_jsd 0.212s 0.211s -0.2% 20 / 20
Total 2.495s 2.498s +0.1% N/A

Iterations: 1 warmup + 20 measured
Samples are shown as main / PR; long pytest benchmarks may use fewer samples.

mark14wu added a commit that referenced this pull request Oct 14, 2026
@mark14wu
[COMPAT] Move the Python 3.12 requirement to #507
5dd2bde 
The version files go back to main's. #507 requires Python 3.12, and
this PR depends on it.
@mark14wu mark14wu mentioned this pull request Oct 14, 2026
Merged
@mark14wu
mark14wu added this pull request to stack #508 October 14, 2026 20:10
@mark14wu mark14wu mentioned this pull request Oct 14, 2026
Open
@Jokeren
Jokeren merged commit 6b7c860 into main Oct 14, 2026
5 checks passed
@Jokeren
Jokeren deleted the compat/require-python-3.12 branch October 14, 2026 20:59
Jokeren pushed a commit that referenced this pull request Oct 14, 2026
@mark14wu @Jokeren
[COMPAT] Move the Python 3.12 requirement to #507
ad9517f 
The version files go back to main's. #507 requires Python 3.12, and
this PR depends on it.
mark14wu added a commit that referenced this pull request Oct 14, 2026
@mark14wu
[COMPAT] Restore main's Python 3.12 requirement
e7de857 
Rebasing onto #507 replayed "Move the Python 3.12 requirement to #507",
which put the 3.10 version files back.
mark14wu added a commit that referenced this pull request Oct 14, 2026
@mark14wu
[DOCS] Never set files back to the base's version in a stacked PR
e8e9fe3 
When #507 merged, GitHub rebased #494 onto main and replayed such a
commit as a revert of #507.
@mark14wu mark14wu mentioned this pull request Oct 14, 2026
Open
mark14wu added a commit that referenced this pull request Oct 14, 2026
@mark14wu
[DOCS] Describe the rebase GitHub does after the bottom PR merges
6443393 
When #507 merged, GitHub rebased #494 onto main instead of only
retargeting it, so the merge -s ours step moves up to the PR above the
rebased one.
mark14wu added a commit that referenced this pull request Oct 15, 2026
@mark14wu @claude
Merge main at #507 into ir-mode-core
e0aec0e 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mark14wu added a commit that referenced this pull request Oct 15, 2026
@mark14wu @claude
Record #494's rebased first commit as merged
ce6aa4a 
7d36ce5 is dcd8610 rebased onto #507, which the previous merge brought in.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jokeren Jokeren Jokeren approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mark14wu @Jokeren