Skip to content

chore: override eslint-plugin-sonarjs minimatch to clear high alert (#4977) #4978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NoopDog merged 2 commits into from
Oct 13, 2026
Merged

chore: override eslint-plugin-sonarjs minimatch to clear high alert (#4977) #4978

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba0fafb
chore: override eslint-plugin-sonarjs minimatch to ^10.2.3 (#4977)
NoopDog Oct 9, 2026
c2c9f08
chore: scope the sonarjs minimatch override to sonarjs 3.x (#4977)
NoopDog Oct 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 0 additions & 39 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,5 +111,10 @@
},
"engines": {
"node": "22.13.0"
},
"overrides": {
"eslint-plugin-sonarjs@^3": {

@frano-m frano-m Oct 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Low / maintainability: This override is effectively a hidden pin. The only note saying to remove it once sonarjs moves to 4.x is in the PR description, and package.json can't hold a comment.

When eslint-plugin-sonarjs goes to ^4, the @^3 key will stop matching. The overrides block will then sit here as dead config, and nothing in the repo will say why it exists or that it can be deleted.

Suggestion: open a follow-up issue (e.g. "upgrade eslint-plugin-sonarjs to 4.x and remove minimatch override") linked from #4977, or add a note next to the sonarjs import in eslint.config.mjs.

"minimatch": "^10.2.3"
}
}
}
Loading