Repository navigation
Modified the basic_multiapp_test to take advantage of process startup wait conditions... - #1068
Merged
Merged
Conversation
…rom drunc_integtest_bundle.sh to improve handling of spaces in the argument list.
… integrationtest infrastructure that help to improve the robustness of waiting for app startup and command completion .
…rtup_improvements
…rtup_improvements
…artup_improvements
PawelPlesniak
approved these changes
Sep 29, 2026
PawelPlesniak
left a comment
Collaborator
There was a problem hiding this comment.
Thank you Kurt!
The associated CI workflow is from outside of this PR, so should be ignored.
20 tasks
emmuhamm
added a commit
that referenced
this pull request
Oct 1, 2026
emmuhamm
added a commit
that referenced
this pull request
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...which were recently added to the
integrationtestinfrastructure.Description
These changes are coupled with DUNE-DAQ/integrationtest#172. Please see that Pull Request for background information on these changes and suggestions for testing them.
In summary, the problem was that, in certain cases, the
integrationtestinfrastructure was not waiting long enough for control process(es) to start. This situation has been improved with changes in theintegrationtestrepo, and the changes to thebasic_multiapp_testtake advantage of those changes (and serve as an example of the use of the updated 'wait conditions').Type of change
List of required branches from other repositories
These changes should be reviewed and tested in conjunction with DUNE-DAQ/integrationtest#172.
Suggested manual testing checklist
Please see the suggestions for testing these changes in DUNE-DAQ/integrationtest#172.