Repository navigation
Conversation
tdonohue
reviewed
Oct 2, 2026
tdonohue
left a comment
tdonohue
left a comment
Member
There was a problem hiding this comment.
@MMilosz : Good catch that the docs are slightly wrong here. Your updates mostly look good, but there's some minor inconsistencies that I describe below. Once you cleanup those inconsistencies, then I think this is ready to merge.
| }, | ||
| "self": { | ||
| "href": "http://localhost:8080/server/api/core/bitstreams" | ||
| "href": "http://localhost:8080/server/api/core/bitstreams?size=5" |
Member
There was a problem hiding this comment.
To make this more accurate, it likely should say page=1 here, assuming next is page=2.
| "href": "http://localhost:8080/server/api/core/bitstreams?page=0&size=5" | ||
| }, | ||
| "prev": { | ||
| "href": "http://localhost:8080/server/api/core/bitstreams?page=1&size=5" |
Member
There was a problem hiding this comment.
Similar to the comment below, to make this more accurate, it likely should be page=0. Essentially, prev, self and next should always be incrementing numbers for the page param.
tdonohue
added
1 APPROVAL
tdonohue
added
port to dspace-8_x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was always
prev, notprevious- fixed to matchAlso, included the
searchlinkUpdated the example parameters so they make sense for
totalElements=14, including showing thatselfis indeed a parameterized link