Repository navigation
ci: tolerate version-only differences in THIRD_PARTY_LICENSES.md and the SBOM; exact check at release - #179
Merged
Merged
Conversation
…ents Dependabot does not run gen_third_party_licenses.py or gen_sbom.py, so every one of its pull requests failed CI on a version string (#154 #156 #157 #158 #176). --check now compares with semantic versions masked and still fails on an added or removed crate, a second version of a crate, a licence or a notice change. --check --strict compares exactly; the release gate runs it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
check_doc_refs.py reads any *.md string in tracked files as a document citation. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependabot does not run
ci/gen_third_party_licenses.pyorci/gen_sbom.py, so every one of its pull requests failed the "python sidecars + configs" job on a version string inTHIRD_PARTY_LICENSES.md(#154, #156, #157, #158, #176), and needed a regeneration commit by hand.Change
ci/_lockfile_versions.py:--checkcompares the committed and regenerated text with every semantic version masked (x.y.z, with pre-release and build suffixes such as2.0.16+zstd.1.5.7; two-part numbers like "Version 2.0" and years are left alone). A version-only difference passes with a note that names the regeneration command.--check --strictcompares exactly.release.yml(validate-tag) now runs it for both files aftercargo fetch --locked, so a tagged release always ships documents that name the exact versions inside the binary. The release PR regenerates both files, as before.tests/python/test_lockfile_versions.py(6 tests); docs/14 and the CHANGELOG updated.Validation
up to date.cargo update -p thiserror(the build(deps): Bump thiserror from 2.0.20 to 2.0.21 in /rust/mumdia in the rust-minor-and-patch group across 1 directory #176 bump, 2.0.20 -> 2.0.21):--checkrc 0 with the note for both files,--check --strictrc 1 for both.pytest tests/python/test_lockfile_versions.py: 6 passed;check_workflows.py,check_doc_refs.py,compileallclean.🤖 Generated with Claude Code