Repository navigation
Conversation
haikoschol
approved these changes
Nov 9, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Two CI breakages, neither caused by code changes on
development: one comes from Debian's archive move, the other from the newubuntu-latestrunner image.Dockerfile: bullseye → bookwormBase images move from Debian 11 (bullseye) to Debian 12 (bookworm),
golang:1.24.1-bullseye→golang:1.24.1-bookwormanddebian:bullseye-slim→debian:bookworm-slim.Bullseye's LTS has ended and its security updates moved to
archive.debian.org. Thebullseye-securityindex ondeb.debian.orgis frozen but still lists packages whose files are gone, so the builder stage'sapt-get install gcc cmake wgetfails:That breaks every
docker-*workflow, four of which are required checks ondevelopment. Bookworm has LTS support until June 2028. Go stays at 1.24.1, which has no trixie image.dot/networktests: advertise loopbackcreateTestServicenow setsPublicIPto127.0.0.1when a test sets neitherPublicIPnorPublicDNS.Without it, each test node looks up its public IP (
pubip.Get()) and advertises it next to its listen addresses.multiaddrs()sorts them byte-wise, so a public IP below 127 comes first. Seven tests dial onlymultiaddrs()[0](TestMinPeers,TestMaxPeers,TestPersistentPeers,TestRemovePeer,TestSetReservedPeer,Test_AddReservedPeers,Test_RemoveReservedPeers). On theubuntu-26.04runners, whose public IPs are20.x, that dial to the runner's own public IP never completes and the peer counts stay at 0. They fail on every run, regardless of the diff.With loopback advertised,
multiaddrs()is just127.0.0.1, and the tests no longer call the external IP-lookup services.TestExternalAddrsPublicIPandTestExternalAddrsPublicDNSset their own values and are unaffected.TestExternalAddrsstill passes, but no longer exercises the real lookup.Tests
The
docker-*workflows on this PR build thebuildertarget and run their suites in it; all five pass.Locally (linux/arm64),
docker build --target builder .anddocker build .both succeed.For
dot/network,pubip.Get()was overlaid to return the CI runner's IP:go test -tags integration ./dot/network/Issues
Blocks #4853, whose required
docker-*checks fail on this.