Repository navigation
test(media-server): make the Railway Dockerfile test chain pass on slow build machines - #4261
Merged
Merged
Conversation
…ow build machines The checkVideoAccessible test asked about a name that does not exist. Since the address guard resolves names itself with a 10 s limit, a build machine whose resolver is slow to give up ran past the 5 s test timeout. It now uses a local server for the missing file and covers a file that exists. Five checks that no decoder is left after a deadline or failure looked the instant the call failed. On a slow machine a stopped decoder is still exiting then. They now wait up to 2 s, so a decoder that was never stopped still fails them.
|
Sandchest reviewed Sandchest reviews every change for vulnerabilities an attacker could use · Review details |
Member
Author
|
@greptileai review |
![capy-ai[bot]](https://avatars.githubusercontent.com/in/1915919?s=60&v=4){kind=small}
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Railway media server builds
apps/media-server/Dockerfile, whose image build runs a long chain ofbun teststeps. That build has failed on every media server change since the address guard landed.Dockerfile.standalone, the farm and self-hosting image, kept passing. Both causes are tests that depend on how fast the build machine is.Reproduced by building
apps/media-server/Dockerfileat main on a 2-CPU Linux machine: the build stopped in the test step about 70 s in, matching the Railway failures.Causes and fixes
checkVideoAccessibledepended on outside DNS. The test asked about a domain that does not exist. Since the address guard resolves names itself with a 10 s limit, a machine whose resolver is slow to give up ran past the 5 s test timeout. The test now uses a local server that answers 404 for the missing file, and a second case checks a file that exists.recording-verification.integration.test.tscheck that no decoder is left after a deadline or failure, and they looked at the instant the call failed. On a slow machine a stopped decoder is still exiting then. A newdecodersStoppedhelper waits up to 2 s. A decoder that was never stopped is still there after the wait, so a real leak still fails.Test files only. No runtime code changes.
Tests
apps/media-server/Dockerfilebuild passes on the same 2-CPU Linux machine and the image is written.
This test-only PR appears safe to merge.Summary
This PR changes only media-server tests.
No actionable issues found. Tests and Docker builds were not run during this review.
Reviews (1) · Last reviewed commit: "test(media-server): make the Railway Doc..." · Reviewed by Greptile