Repository navigation
feat(desktop-gpui): restore the recordings overlay after a Studio recording - #4258
Open
richiemcilroy wants to merge 4 commits into
Open
richiemcilroy wants to merge 4 commits into
richiemcilroy wants to merge 4 commits into
Conversation
|
Sandchest reviewed Sandchest reviews every change for vulnerabilities an attacker could use · 1 credit · Review details |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Member
Author
|
hey @greptileai, please re-review the PR |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Brings back the floating overlay that followed a Studio recording in 0.6.0 when "After a Studio recording" was set to show it.
Why it was missing
RecordingsOverlayfromapply_post_studio_editor_behaviour(apps/desktop/src-tauri/src/recording.rs:5963-5975at800ab28de^).showOverlaybut labelled it "Show Cap", and the stop flow sent it to the fallback arm that reshows the main window (app_windows.rs, phase observer).flowchart LR stop[Studio recording stops cleanly] --> rules[automation rules<br/>SkipEditor / OpenEditor] rules --> b{postStudioRecordingBehaviour} b -- openEditor --> editor[editor] b -- showOverlay --> overlay[recordings overlay<br/>main window stays hidden] b -- doNothing --> lib[library only] shot[screenshot taken] -- overlay already up --> overlayWhat changed
apps/desktop-gpui/src/recordings_overlay.rs(new): a stack of 260x150 cards, newest on top, in the bottom-left corner of the display under the cursor. Hovering a card shows the Tauri card's actions:upload_exported_videowith the organization picked in the export dialog (first one if it is gone), with progressupload_rendered_screenshotand saves the link on the bundleNewScreenshotAdded. Screenshots do not open the stack by themselves (Tauri never did that either).postStudioRecordingBehaviouris unchanged on disk.showOverlay, written by 0.6.0 for its overlay and by 0.6.1 to 0.6.3 for "Show Cap", now means the overlay again and is labelled "Show in overlay" (Shortcuts page outcome: "Show overlay"). Nothing new is written, so a downgrade to 0.6.0 still reads it.studio_editor_behaviourmapsSkipEditortodoNothingandOpenEditortoopenEditor, so the overlay is suppressed and the editor wins exactly as in Tauri'sstudio_recording_editor_behaviour. No change is needed on either side; the hooks here avoid the lines feat(desktop-gpui): run saved automation rules #4059 touches.editor_export::run_export,export_file_name,app_windows::gpui_display_id,remove_popup_window_chrome.Callers checked
postStudioRecordingBehaviourreaders: the phase observer match (app_windows.rs),open_preparing_studio_editorandprepares_studio_editor(onlyopenEditorprepares an editor;showOverlaystill waits for finalization before the card appears, so actions never run on an unfinished recording), the Shortcuts page outcome cards and effect sentences (settings_pages.rs, unchanged wording for non-editor outcomes).prepare_for_screenshot_captureandscreenshot_finished(both screenshot paths, including Wayland'sempty_overlays_for_screenshot, go through them).run_exportkeeps its single editor caller; signature unchanged.What could regress
showOverlaysaved from 0.6.1 to 0.6.3 now see the overlay instead of the main window coming back. That is the intent: the value always meant the overlay, and GPUI's own comment called the reshow a stand-in "until an overlay exists".Tests
recordings_overlay::tests(15): completion per behaviour, organization choice, corner placement and the work-area clamp, the card limit, overflow keeping busy cards, progress and titles for every state, a screenshot joining only an open stack, deleted recordings dropped on return, one action at a time with Close cancelling, a deleted recording closing its card, Done and Failed settling back.store::tests::post_studio_overlay_reads_tauri_and_gpui_stores: a full 0.6.0general_settingsobject and a GPUI single-key store both readshowOverlayas the overlay; unknown and absent values stayopenEditor.Proof
Media and real-app runs on macOS follow in a comment.


Confidence Score: 5/5
The PR appears safe to merge; no new blocking issue was found.Summary
Restores the recordings overlay for the saved
showOverlaysetting, with copy, share, export, and editor actions.Reviews (2) · Last reviewed commit: "fix(desktop-gpui): ask about export reso..." · Reviewed by Greptile