Repository navigation
fix(desktop-gpui): mirror the teleprompter script when Mirror text is on - #4250
Open
richiemcilroy wants to merge 4 commits into
Open
richiemcilroy wants to merge 4 commits into
richiemcilroy wants to merge 4 commits into
Conversation
richiemcilroy
marked this pull request as ready for review
November 14, 2026 05:25
|
Sandchest reviewed Sandchest reviews every change for vulnerabilities an attacker could use · Review details |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Member
Author
|
hey @greptileai, please re-review the PR |
![capy-ai[bot]](https://avatars.githubusercontent.com/in/1915919?s=60&v=4){kind=small}
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The teleprompter's Mirror text toggle saved but changed nothing. This adds a GPUI patch for a horizontal mirror and uses it on the script, with clicks and the IME box following the mirrored text. Draft while proof runs; full write-up to follow.
The PR appears safe to merge; no new actionable issue was found.Summary
Makes the teleprompter’s Mirror text toggle flip the script.
The earlier test-coverage thread was manually resolved without explanation.
Reviews (2) · Last reviewed commit: "ci: run the GPUI mirror patch tests" · Reviewed by Greptile