Update bgfx.cmake to f587fa75 - #1911
Merged
bkaradzic-microsoft merged 1 commit intoOct 2, 2026
Merged
Conversation
Advance the dependency pin to the latest BabylonJS/bgfx.cmake revision, including the updated bgfx, bimg, and bx submodules. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: e6c3c123-c355-4790-a3d4-94337ed6e052
bghgary
approved these changes
Oct 2, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The new revision exists and contains exactly the three documented submodule updates.
Review effort: Balanced
Findings: None
What changed in this PR
Updates the pinned bgfx.cmake revision to include upstream bgfx, bimg, and bx updates from PR #154.
Changes:
- Advances
bgfx.cmakefrom9a7a35edtof587fa75. - Introduces no BabylonNative source changes.
| File | Description |
|---|---|
CMakeLists.txt |
Updates the bgfx.cmake dependency pin. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update only the
bgfx.cmakepin inCMakeLists.txt, based on BabylonNative master5051e985.9a7a35ed0d588c64de867c5e5c7f990676da8c21->f587fa75d7b980838698c6492d39d2c6c86558d7(latest upstream revision when opened).Picks up BabylonJS/bgfx.cmake#154:
22174cf4312d3e1d1529b27936c814face282f22->f8a35123b9bcce36dc85560cbcd9f7a0a69ac99cc085da683d033c8d788eb5c261ab35d4c090231c->8869e43603e788a63a6ddf737545dcc055a49dc11c986bd1e9a176a08ae885a6cdcefe76c3f700fc->74adb68722ba342ac557523aad68a4e1a1037b66No BabylonNative source changes or other dependency updates.
Validation
git diff --checkpasses; the PR changes exactly one dependency pin.