Skip to content

fix(explorer-ui-v2): axios 1.21.1 - #42

Merged
alejoamiras merged 1 commit into
mainfrom
deps/ui-axios-1.21
Nov 18, 2026
Merged

alejoamiras merged 1 commit into
mainfrom
deps/ui-axios-1.21

Conversation

@alejoamiras

Copy link
Copy Markdown
Collaborator

What changes

  • services/explorer-ui-v2/package.json: axios 1.7.7 → 1.21.1, still an exact pin.
  • 1.21.1 is the version the backend workspaces already resolve. The lockfile merges the two descriptors into one entry and drops axios 1.7.7 and proxy-from-env 1.1.0. No new package comes in.
  • New test src/api/client.test.ts (2 tests, about 10 ms). It covers two client behaviours:
    • request building: the base URL and path are joined, and undefined params are dropped;
    • error mapping: an error response with status 500 becomes an ApiError with that status and the response body as its message.
    • Both tests pass on 1.7.7 and on 1.21.1.

Advisories

A simulation against the open alert list predicts 66 closures: 26 high, 38 medium, 2 low. 33 are on services/explorer-ui-v2/package.json and 33 on yarn.lock. No axios alert stays open, and none opens.

Local gates

Gate Result
yarn install --immutable pass; the same peer warnings as the base
yarn build:packages && yarn build pass
yarn lint, then git diff --exit-code pass, no changes
yarn test pass: 252 tests, the 2 new ones included, none skipped
UI in a browser pass, see below

UI build and browser check

  • The production bundle grows by 24,057 bytes of JS (8,134 gzipped): 1,407,634 bytes against 1,383,577. CSS and the file count (62) are unchanged.
  • A build with placeholder settings (VITE_L2_NETWORK_ID=SANDBOX, an unreachable API and WebSocket host, the non-production API key), served by vite preview and loaded in headless Chromium with every off-host request blocked:
    • /, /about-us and /blocks render, and an in-app link to /about-us navigates;
    • the lazy route chunks and all 25 assets load with 200;
    • requests to the placeholder API host are made and blocked, as intended;
    • there is no uncaught exception, and the only console errors are the blocked requests.

🤖 Generated with Claude Code

The UI pinned axios 1.7.7 exactly. 1.21.1 is the version the backend workspaces already resolve,
so the lockfile drops the separate 1.7.7 entry and its proxy-from-env 1.x dependency.

src/api/client.test.ts covers two client behaviours: how a request URL is built from the base URL
and params, and how an error response becomes an ApiError. Both tests pass on 1.7.7 and on
1.21.1.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@alejoamiras
alejoamiras merged commit 364182c into main Nov 18, 2026
24 checks passed
@alejoamiras
alejoamiras deleted the deps/ui-axios-1.21 branch November 18, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant