Skip to content

fix: preserve links and mentions in Slack lists - #10447

Merged
Soulter merged 1 commit into
AstrBotDevs:masterfrom
wcqqq1214:fix/slack-list-inline-elements
Oct 9, 2026
Merged

Soulter merged 1 commit into
AstrBotDevs:masterfrom
wcqqq1214:fix/slack-list-inline-elements

Conversation

@wcqqq1214

@wcqqq1214 wcqqq1214 commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

AstrBot's Slack adapter drops links and user mentions inside bulleted and numbered lists. A bot mentioned only in a list may not respond.

Slack officially supports this content: its rich_text_list documentation allows link and user elements within list item sections for both bullet and ordered lists.

Modifications / 改动点

Reuse existing section parsing for list items, preserving links, mentions, and text order. Add regression coverage for both list styles.

  • This is NOT a breaking change. / 这不是一个破坏性变更。

Screenshots or Test Results / 运行截图或测试结果

Verification: send a link in a Slack list with the bot mention outside it, then send a list containing the only bot mention. Repeat with numbered lists. Links should reach the bot, and mentions should trigger a response.

  • 82 related tests passed; ruff format . and ruff check . passed.
  • Container smoke tests passed for both list styles.

Before

Before

After

After

Checklist / 检查清单

  • 😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
    / 如果 PR 中有新加入的功能,已经通过 Issue / 邮件等方式和作者讨论过。

  • 👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
    / 我的更改经过了良好的测试,并已在上方提供了“验证步骤”和“运行截图”。

  • 📚 I checked the affected WebUI instructions and screenshots in docs/zh and docs/en against the changed navigation, page structure, and labels, and updated them in this PR (or explained why no documentation update is needed). For renamed, moved, or merged entry points, I included an old entry → new entry mapping in the documentation and changelog.
    / 我已对照变化后的 WebUI 入口、页面结构和术语,核对并在本 PR 中更新 docs/zh 和 docs/en 的相关操作说明与截图(或说明无需更新文档的原因)。入口改名、移动或合并时,已在文档和 changelog 中补充 旧入口 → 新入口 对照。

  • 🤓 I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in requirements.txt and pyproject.toml.
    / 我确保没有引入新依赖库,或者引入了新依赖库的同时将其添加到 requirements.txt 和 pyproject.toml 文件相应位置。

  • 😮 My changes do not introduce malicious code.
    / 我的更改没有引入恶意代码。

Summary by Sourcery

Preserve rich-text links and mentions in Slack list messages so linked content remains intact and mentions can trigger bot responses.

Bug Fixes:

  • Preserve links, user mentions, and their ordering when parsing Slack bulleted and numbered rich-text lists.

Tests:

  • Add regression coverage verifying link and mention preservation for both bullet and ordered Slack lists.

@wcqqq1214
wcqqq1214 marked this pull request as ready for review October 7, 2026 18:03

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@Soulter
Soulter merged commit 5994167 into AstrBotDevs:master Oct 9, 2026
23 checks passed
@wcqqq1214
wcqqq1214 deleted the fix/slack-list-inline-elements branch October 9, 2026 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants