Skip to content

fix: prevent Discord self-reply loops - #10425

Merged
Soulter merged 2 commits into
AstrBotDevs:masterfrom
wcqqq1214:fix/discord-self-message-loop
Oct 9, 2026
Merged

Soulter merged 2 commits into
AstrBotDevs:masterfrom
wcqqq1214:fix/discord-self-message-loop

Conversation

@wcqqq1214

@wcqqq1214 wcqqq1214 commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Enabling discord_allow_bot_messages(允许接受机器人消息) also accepts the bot's own replies. With default private-chat settings, a single message can trigger a self-reply loop.

Modifications / 改动点

  • Ignore the connected bot's own messages before dispatch; preserve filtering for other bots.

  • Add six regression cases covering self, other bots, and human senders with the setting on/off.

  • This is NOT a breaking change. / 这不是一个破坏性变更。

Screenshots or Test Results / 运行截图或测试结果

Verification: enable discord_allow_bot_messages, leave ignore_bot_self_message and friend_message_needs_wake_prefix disabled, and send one DM. Expect one reply without further self-triggered replies.

Automated: 19 Discord tests passed; ruff format ., ruff check ., and git diff --check passed. The regression failed before the fix.

Before

Before

After
After


Checklist / 检查清单

  • 😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
    / 如果 PR 中有新加入的功能,已经通过 Issue / 邮件等方式和作者讨论过。

  • 👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
    / 我的更改经过了良好的测试,并已在上方提供了“验证步骤”和“运行截图”。

  • 📚 I checked the affected WebUI instructions and screenshots in docs/zh and docs/en against the changed navigation, page structure, and labels, and updated them in this PR (or explained why no documentation update is needed). For renamed, moved, or merged entry points, I included an old entry → new entry mapping in the documentation and changelog.
    / 我已对照变化后的 WebUI 入口、页面结构和术语,核对并在本 PR 中更新 docs/zh 和 docs/en 的相关操作说明与截图(或说明无需更新文档的原因)。入口改名、移动或合并时,已在文档和 changelog 中补充 旧入口 → 新入口 对照。

  • 🤓 I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in requirements.txt and pyproject.toml.
    / 我确保没有引入新依赖库,或者引入了新依赖库的同时将其添加到 requirements.txt 和 pyproject.toml 文件相应位置。

  • 😮 My changes do not introduce malicious code.
    / 我的更改没有引入恶意代码。

Summary by Sourcery

Prevent Discord self-reply loops by filtering the connected bot’s own messages before dispatch.

Bug Fixes:

  • Prevent Discord messages sent by the connected bot from being processed, eliminating self-reply loops while retaining configurable handling of other bot messages.

Tests:

  • Add regression coverage for self messages, other bot messages, and human messages with bot-message filtering enabled and disabled.

@wcqqq1214
wcqqq1214 marked this pull request as ready for review October 6, 2026 21:07

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@Soulter
Soulter merged commit d2fb912 into AstrBotDevs:master Oct 9, 2026
23 checks passed
@wcqqq1214
wcqqq1214 deleted the fix/discord-self-message-loop branch October 9, 2026 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants