feat(dashboard): add a first-run setup guide - #10329
Open
camera-2018 wants to merge 13 commits into
Open
camera-2018 wants to merge 13 commits into
camera-2018 wants to merge 13 commits into
Conversation
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="dashboard/src/components/OnboardingSetup.vue" line_range="32" />
<code_context>
+ <strong>{{ tm('guide.platformReady') }}</strong>
+ </div>
+ <AddNewPlatform v-else-if="!configError" ref="platformForm" embedded :show="true" :metadata="platformMetadata"
+ :config_data="platformConfig" @refresh-config="loadPlatforms" @update:busy="busy = $event"
+ @show-toast="platformError = $event.type === 'error' ? $event.message : ''" />
+ <v-btn v-else variant="text" @click="loadPlatforms">{{ tm('guide.retry') }}</v-btn>
</code_context>
<issue_to_address>
**issue (bug_risk):** Saving a new messaging adapter does not advance from step 4. `AddNewPlatform` emits `refresh-config` with the created platform ID, but the handler passes no ID to `loadPlatforms`; `nextStep` then returns immediately after starting `newPlatform()`, so the guide remains on the adapter step and requires a second click on Next.
**Triggers:** When the user successfully saves an adapter from the embedded platform form.
**Suggested fix:** Pass the emitted platform ID to `loadPlatforms` and advance to step 5 after the save completes, or have `nextStep` await a save result and increment the step itself.
</issue_to_address>Sourcery assessment
Needs a human reviewer. 1 finding to address first, and the guide changes authenticated login and setup routing, can change computer-access permissions, and installs externally hosted plugins whose code and effects persist beyond reverting this UI change. A revert restores the old entry points but does not automatically remove installed plugins or undo permission changes.
Blocking findings: dashboard/src/components/OnboardingSetup.vue:32
RC-CHN
approved these changes
Oct 3, 2026
Member
|
宝宝我们男女搭配干活不累 |
camera-2018
force-pushed
the
codex/webui-first-run-guide
branch
from
October 3, 2026 16:10
baa6f6f to
33b49a2
Compare
Member
|
good! 感觉第五和第六步可以先暂时去掉 |
Contributor
Author
|
@Soulter 我把原来的欢迎主页面删了 如果把第5、6步删了的画 是不是要加回来原来的欢迎页?这样感觉有点冲突 欢迎太多了🤔 |
Member
|
不用加回来!关于 "agent use computer" 这块,我打算在 #10321 中将这里的设置入口在配置文件中变得更浅显一些,这样也可以不用在onboard设置。
Soulter
***@***.***
|
Add an isolated Playwright E2E flow, remove the unused mock adapter dependency, and refine the welcome stars animation. Keep the local account setup fix separate.
camera-2018
force-pushed
the
codex/webui-first-run-guide
branch
from
October 6, 2026 16:31
ffe2f0c to
47af1ec
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a skippable first-run guide after account setup, using existing WebUI components.
Includes four UI locales, Chinese/English documentation, and tests. Account setup returns an explicit onboarding eligibility flag. Plugin installation and computer-access settings remain outside the guide.
Demo
astrbot-onboarding-real.mp4
Real-backend walkthrough: model response, adapter setup, configuration reentry, and routing edits.
Testing
Screenshots
Checklist
canvas-confetti1.9.4; development-only@types/canvas-confettiandplaywright1.63.0. Removed unusedaxios-mock-adapter.