Add `video-codecs` meson option to limit the supported codecs by jannau · Pull Request #6 · AsahiLinux/avd-fw

jannau · 2026-10-15T11:26:32Z

For legal reasons distribution might not be able to ship support for all codecs. Allow them to limit the support in the firmware. User will be able to install firmware with full support to /lib/firmware/updates/.

Goes together with AsahiLinux/linux@0f086c1

Also embed basic firmware information in the binary. The Makefile build does not support this so drop it rather than adding support.

This is based on the same option in mesa's meson.build / meson.options and defaults to "all_free" which is av1 and vp9.

Please check all boxes that apply:

This code was developed in accordance with the Asahi Linux Copyright Policy
I have not used generative AI/LLMs to develop this code, in accordance with the Asahi Linux LLM Policy
I have certified the above by adding a Signed-off-by: trailer to every commit

All boxes must be checked before your pull request can be reviewed.

jannau · 2026-10-15T11:27:35Z

Option and meson implementation is based on the option with the same name in mesa

sofus13 · 2026-10-22T20:03:37Z

@@ -0,0 +1,12 @@
+SECTIONS {
+    . = 0x00000000;
+    .vectors : { *(.vectors) }


Can we put config/license after vectors? vectors should use at most 0x400 bytes, 240 interrupts + 16 entries (sp, nmi and friends). I kinda wanna reserve at least 256 bytes for config

done. It's a little tight with the text. only 12 byte remaining from 0x280 to 0x300

What about something like

.vectors : { *(.vectors) } . = 0x00000400; .config : { *(.config) } . = 0x00000500; .license : { *(.license) } =0x00 .text : { *(.text*) }

Each version of hardware has gotten more interrupts, this should work as long as its an Cortex-m3

I misread your comment. that layout is fine by me. I'll update the PR

sofus13 · 2026-10-22T20:10:14Z

 ]

+conf_data = configuration_data()
+conf_data.set_quoted('AVD_FW_VERSION', meson.project_version())


Is there a downside to using git tags instead?

The are not available in tarballs downloaded from git tags. Switched anyway and using https://mesonbuild.com/Creating-releases.html#cement-a-version-obtained-from-vcs which means we have to use github releases and upload our own tarballs generated by meson dist

Sorry. I should have made it clear that it was more of a question. I was not aware of the tarballs missing the tags.
Manual tarballs seem kinda annoying and i think it would break how distros package it. I dont think its worth the tradeoff

it's a tradeoff. The hardcoded version in meson build is also something which can be easily forgotten and then build will report a different version than the tag.
I plan to write a CI workflow which produces dist tarballs. Still requires to download the tag's artifacts and upload them to the release. There doesn't seem to be a way tell github that (I haven't searched for it either though).

I'll split this off to a separate PR

Otherwise the targets won't be rebuilt on avd-cm3.ld changes. Fixes: 1bc7a80 ("build: Add meson build") Signed-off-by: Janne Grunau <j@jannau.net>

Those includes define data and must be included only once. Allows to use avd.h to define values and data types as expected from a header. Signed-off-by: Janne Grunau <j@jannau.net>

Signed-off-by: Janne Grunau <j@jannau.net>

The bitmask of enabled codecs is embedded in the 256-byte large config struct at offset 0x400 of the firmware binary. This uses meson's configuration_data / configure_file so remove the Makefile as it is no longer supported. Signed-off-by: Janne Grunau <j@jannau.net>

sofus13 · 2026-10-25T10:00:48Z

+option(
+  'video-codecs',
+  type : 'array',
+  value : ['all_free'],


Would either all or none, be a better default? Using all would be to mirror the fw we would submit to linux-firmware while not having a default would be to avoid confusion

This is uses the same default as mesa and is based on the principle of least bad surprise for distro packagers. I'd argue the default matters even less since linux firmware will distribute binaries. To avoid confusion the change adding the firmware binaries to linux-firmware should mention that. It might make sense to to include both all and all_free builds in linux-firmware so distros can chose in their packaging.

For linux-firmware we would still need to choose a default, which would presumably be the all build. In my head it was better if the distro packagers already knew that our fw would need special handling. Hence the default of all (convenient and no breaking change) or none (needs an active choice, impossible to ignore).

It does not really matter. The all_free default does not hurt anyone and is easy spot so im ok with it, thanks

sofus13 · 2026-10-25T10:07:03Z

The last commit still refers to the old layout. Please also enable all codecs in the ci

Embed the project name, version and copyright information before the firmware code after the embedded config struct. Signed-off-by: Janne Grunau <j@jannau.net>

…ilds Replaces the previous ci workflow. Signed-off-by: Janne Grunau <j@jannau.net>

jannau force-pushed the codec-selection branch from d7c7833 to 9f06f88 Compare October 15, 2026 11:38

sofus13 requested changes Oct 16, 2026

View reviewed changes

Comment thread meson.build Resolved

Comment thread meson.build Resolved

jannau force-pushed the codec-selection branch 3 times, most recently from 8be883f to 6b3c125 Compare October 21, 2026 21:56

sofus13 requested changes Oct 22, 2026

View reviewed changes

jannau force-pushed the codec-selection branch 2 times, most recently from fc7755c to 0b166e1 Compare October 22, 2026 22:41

jannau added 4 commits October 24, 2026 22:24

build: Add ld_scripts as link_depends for elf targets

5c2a218

Otherwise the targets won't be rebuilt on avd-cm3.ld changes. Fixes: 1bc7a80 ("build: Add meson build") Signed-off-by: Janne Grunau <j@jannau.net>

Move includes from avd.h to avd.c

1994a39

Those includes define data and must be included only once. Allows to use avd.h to define values and data types as expected from a header. Signed-off-by: Janne Grunau <j@jannau.net>

build: Specify the license in the meson project()

2fd9836

Signed-off-by: Janne Grunau <j@jannau.net>

jannau force-pushed the codec-selection branch 2 times, most recently from bf13855 to d3fea30 Compare October 24, 2026 20:45

jannau added this pull request to stack #8 October 24, 2026 21:05

sofus13 reviewed Oct 25, 2026

View reviewed changes

build: Embed project name, version and copyright information

f484565

Embed the project name, version and copyright information before the firmware code after the embedded config struct. Signed-off-by: Janne Grunau <j@jannau.net>

jannau force-pushed the codec-selection branch 5 times, most recently from f7620b9 to b94106b Compare October 25, 2026 13:41

CI: Add workflows for -Dvideo-codecs=all / -Dvideo-codecs=all_free bu…

d1b5744

…ilds Replaces the previous ci workflow. Signed-off-by: Janne Grunau <j@jannau.net>

jannau force-pushed the codec-selection branch from b94106b to d1b5744 Compare October 25, 2026 13:42

sofus13 merged commit 4488613 into main Oct 28, 2026
3 checks passed

jannau deleted the codec-selection branch October 31, 2026 14:23

Conversation

jannau commented Oct 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jannau commented Oct 15, 2026

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sofus13 commented Oct 25, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jannau commented Oct 15, 2026 •

edited

Loading