Repository navigation
[LLM] feat: Add Wikipedia donation link to About screen - #169
Merged
Merged
Conversation
Add a link in the About screen after the 'How this works' methodology section to allow users to donate to Wikipedia. What: - Added 'Thank Wikipedia by donating' link row in the About screen references section. - Attributed donation traffic using official UTM tracking parameters (utm_source=JanusGlossa, utm_medium=AndroidApp, utm_campaign=JanusGlossa). - Localized the link string across all supported languages (English, Arabic, German, Spanish, French, Hebrew, Russian). - Added unit tests in AboutScreenTest verifying display and ACTION_VIEW intent resolution. Why: Janus Glossa's core functionality is powered by Wikipedia's inter-language graph. Adding an attributed donation link enables users to support the Wikimedia Foundation while giving Janus Glossa visibility in Wikimedia campaign analytics. Committed by Antigravity AI Agent.
Member
|
Great work! The PR cleanly adds the Wikipedia donation link to the About screen, safe URL launch handling with clipboard fallback, complete localization across all 7 supported languages, and thorough unit tests. |
anysoftkeyboard-bot
left a comment
anysoftkeyboard-bot
left a comment
Member
There was a problem hiding this comment.
The PR cleanly adds the Wikipedia donation link across localized string files, removes inline package qualifiers, and includes thorough unit tests verifying link rendering and intent creation.
Safely launch web URLs with fallback for devices without browsers or with locked profiles. What: - Introduced `Context.openUrlSafely(url: String)` extension function. - Handled `ActivityNotFoundException` and general launch errors by logging a warning, copying the link to the clipboard, and displaying a user-facing Toast. - Replaced direct `startActivity` calls in both `AboutScreen` (`ReferenceLinkRow`) and `ActionButtons` (`WikipediaLinkButton`). - Added `error_no_browser` localized strings across all 7 supported languages. - Added unit tests in `IntentUtilsTest` and updated `ActionButtonsTest`. Why: Some devices (kiosk mode, restricted/work profiles, headless, or devices without a default browser) throw `ActivityNotFoundException` when resolving implicit web `ACTION_VIEW` intents, causing fatal app crashes. Committed by Antigravity AI Agent.
anysoftkeyboard-bot
left a comment
anysoftkeyboard-bot
left a comment
Member
There was a problem hiding this comment.
The PR cleanly adds the Wikipedia donation link to the About screen, handles safe URL launches with clipboard fallback, includes full localization across all 7 supported languages, and adds thorough unit tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
AboutScreen.ktdirectly after the "How this works" methodology section.https://donate.wikimedia.org/?utm_source=JanusGlossa&utm_medium=AndroidApp&utm_campaign=JanusGlossa, which automatically maps through Wikimedia'sSpecial:FundraiserRedirectortowmf_sourceandwmf_campaignonSpecial:LandingPage.Context.openUrlSafely(url: String)inIntentUtils.ktto protect againstActivityNotFoundExceptionon devices without browsers or with locked profiles.openUrlSafelyacross bothAboutScreen(ReferenceLinkRow) andActionButtons(WikipediaLinkButton). On failure, the URL is automatically copied to the clipboard and a localized Toast is displayed.about_link_donate_wikipediaanderror_no_browser) across all supported languages (Arabic, German, Spanish, French, Hebrew, Russian, and default English).AboutScreenTest,IntentUtilsTest, andActionButtonsTest.Why