[mrienstra]

Currently only the aw-watcher-afk section links to the source of its default config values. This PR adds the same link for aw-server-python, aw-server-rust, aw-client and aw-watcher-window.

Additionally:

• Document the aw-watcher-window exclude_titles option: a list of regular expressions, matched case-insensitively anywhere in the title, and matching titles are replaced with excluded (see transform_window in aw_watcher_window/main.py)
• Format the strategy_macos values as literals
• Add a custom-visualizations label so the custom_static entries link to that section instead of the top of the watchers page

Update: rebased onto current master. #195 has since covered the address/host correction and the custom_static entries, so I dropped those, along with the aw-server-python → aw-server heading rename.

---

Important

Add default config links, correct options, and minor additions to configuration.rst and watchers.rst.

• Configuration Links:
  • Add links to default config values for aw-server, aw-server-rust, aw-client, and aw-watcher-window in configuration.rst.
• Corrections and Additions:
  • Rename aw-server-python to aw-server in configuration.rst.
  • Add custom_static option to aw-server and aw-server-rust.
  • Correct aw-server-rust to use address instead of host.
  • Add exclude_titles option to aw-watcher-window.
• Misc:
  • Add anchor for custom visualizations in watchers.rst.

^{This description was created by for 1ee0145. You can customize this summary. It will automatically update as commits are pushed.}

[ellipsis-dev]

Important

Looks good to me! 👍

Reviewed everything up to 1ee0145 in 1 minute and 4 seconds. Click for details.

• Reviewed 80 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 8 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. src/configuration.rst:13

• Draft comment:
  Renamed 'aw-server-python' to 'aw-server' for consistency with the repo name. Ensure all references are updated accordingly.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

2. src/configuration.rst:20

• Draft comment:
  Added the 'custom_static' option with a link to custom visualizations. Verify that the anchor 'custom-visualizations' exists in the docs.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

3. src/configuration.rst:28

• Draft comment:
  Changed the config key from 'host' to 'address' in the aw-server-rust section. This aligns with the actual implementation.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

4. src/configuration.rst:31

• Draft comment:
  Added the 'custom_static' option for aw-server-rust, mirroring the aw-server configuration. Looks consistent.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

5. src/configuration.rst:41

• Draft comment:
  Updated the description for 'client.commit_interval' for clarity. The new phrasing is clearer.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

6. src/configuration.rst:57

• Draft comment:
  Replaced 'exclude_title' with 'exclude_titles' in the aw-watcher-window section. Confirm that this updated key matches the implementation.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

7. src/configuration.rst:60

• Draft comment:
  Enhanced inline code formatting for macOS strategies (swift, jxa, applescript) for consistency and readability.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

8. src/watchers.rst:85

• Draft comment:
  Added the '.. _custom-visualizations:' anchor to facilitate linking from configuration docs. Good addition for navigability.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

Workflow ID: wflow_QwLaPuxCtpxWY7Yy

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}

[TimeToBuildBob]

Thanks! The exclude_titles entry and the config-source links are both useful additions. To merge:

• The docs build failed on this head. It was a long time ago, so rebase on current master to get a fresh run, and check the new :ref: label (custom-visualizations) resolves.
• Then it needs a review pass of the wording, which I'll do once the build is green.

[TimeToBuildBob]

🤖 AI code review

Adds links to default configuration sources for aw-server-python, aw-server-rust, aw-client, and aw-watcher-window in src/configuration.rst. Documents exclude_titles and formats strategy_macos values as literals. Adds the custom-visualizations label in src/watchers.rst and points both custom_static references to that section.

Safe to merge — no P0/P1 findings

Confidence 5/5

✅ No findings. The diff looks correct to me on this pass.

Files changed (2) — the diff as I read it

• src/configuration.rst — Adds four configuration source links, documents exclude_titles, formats strategy_macos values as literals, and changes custom_static links to section references.
• src/watchers.rst — Adds the custom-visualizations reference label immediately before the Custom visualizations section.

_{Reviewed 71f0ca624e13 · panel: codex:gpt-6.1-sol · subscription engine · 12s · about this reviewer}

_{Maintainer commands}

_{@TimeToBuildBob review (own line) — fresh review · @TimeToBuildBob fix — a worker acts on the findings. Once per comment; 👀 = received.}

Outage coverage: 1-pass, not merge evidence. Subscription review supplied findings while full consensus capacity was unavailable. The consensus merge gate remains unsatisfied.

[mrienstra]

Rebased onto current master (now includes #160). The earlier failure was the CI-wide apt mirror 404 from mid-October: it failed at "Install APT dependencies", before Sphinx ran. It wasn't caused by this change.

I also built it locally with the locked deps on Python 3.13. There are no new warnings compared with master, and the custom-visualizations label resolves: both custom_static entries link to watchers.html#custom-visualizations. Ready for the wording pass whenever you are.