fix(desktop): only a recovered result leaves a duplicate open

Author: waleedlatif1

apps/desktop/src/main/desktop-executor/executor.test.ts

@@ -256,6 +256,23 @@ describe('claiming', () => {
     expect(delivered).toEqual([])
   })
 
+  it('reports a stand-in Sim holds as a duplicate as never reaching the model, within one app run', async () => {
+    const { sim, runner, executor, delivered, notDelivered } = setup()
+    // Too large to send, so Sim never took the real result; the stand-in's first answer was lost.
+    runner.immediate = DONE
+    sim.completeErrors = [
+      new DeviceRequestError(413, 'too large'),
+      new DeviceRequestError(0, 'connection reset'),
+    ]
+    sim.completionOutcome = 'duplicate'
+    sim.inbox = [callItem('call-1', 'chat-a', 'terminal')]
+
+    await executor.reconcile()
+
+    await vi.waitFor(() => expect(notDelivered).toEqual(['call-1']))
+    expect(delivered).toEqual([])
+  })
+
   it('reports a result Sim refused as never reaching the model', async () => {
     const { sim, runner, executor, notDelivered } = setup()
     runner.immediate = DONE
@@ -550,6 +567,24 @@ describe('restarting', () => {
     expect(delivered).toEqual([])
     expect(notDelivered).toEqual([])
   })
+
+  it('reports a recovered result too large to send, then held as a duplicate, as never reaching the model', async () => {
+    const { sim, journal, executor, delivered, notDelivered } = setup()
+    // No run could have sent this result: it is too large every time.
+    sim.completeErrors = [new DeviceRequestError(413, 'too large')]
+    sim.completionOutcome = 'duplicate'
+    await journal.put({
+      toolCallId: 'result-1',
+      state: 'result',
+      executionToken: 't',
+      completion: DONE,
+    })
+
+    await executor.recover()
+
+    await vi.waitFor(() => expect(notDelivered).toEqual(['result-1']))
+    expect(delivered).toEqual([])
+  })
 })
 
 describe('delivery', () => {

apps/desktop/src/main/desktop-executor/executor.ts

@@ -431,9 +431,11 @@ export class DesktopExecutor {
         // Superseded: Sim settled the call first, so this result never reached the model.
         const delivered = outcome !== 'superseded' && isDeliveredResult(pending)
         if (delivered) this.options.onResultDelivered?.(toolCallId)
-        // A stand-in Sim already holds leaves open which result it took first: a send from before
-        // a restart may have carried the real one.
-        notDelivered = !delivered && outcome !== 'duplicate'
+        // A duplicate holds what this app run sent, unless the result was recovered unchanged from
+        // an earlier run, whose send of the real result may have landed before the restart.
+        const takenEarlier =
+          outcome === 'duplicate' && pending === completion && this.recoveringIds.has(toolCallId)
+        notDelivered = !delivered && !takenEarlier
         break
       } catch (error) {
         // Encoding failed on this machine, so nothing was sent; the same data would fail again.