Skip to content

Commit 1ac2d5a

Browse files
authored
Make all the codegen we do incremental (#64331)
1 parent 36482c8 commit 1ac2d5a

35 files changed

Lines changed: 1531 additions & 251 deletions

‎.github/workflows/ci.yml‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -294,12 +294,6 @@ jobs:
294294
- uses: ./.github/actions/setup-go
295295
- run: npm ci
296296
- run: npx hereby generate
297-
- run: npx hereby generate:enums
298-
- run: npx hereby generate:ast
299-
- run: npx hereby generate:vendor
300-
- run: node ./tsc/internal/lsp/lsproto/_generate/fetchModel.mts
301-
- run: node ./tsc/internal/lsp/lsproto/_generate/generate.mts
302-
- run: npx hereby generate:extension
303297
- run: npx hereby check:scripts
304298
- run: git add .
305299
- run: git diff --staged --exit-code --stat

‎CONTRIBUTING.md‎

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,12 +103,20 @@ npx hereby build # Build the native compiler into built/local/tsc
103103
npx hereby test # Run compiler and language-service Go tests
104104
npx hereby test:all # Also run benchmarks, tools, and API tests
105105
npx hereby lint # Run custom golangci-lint for both Go modules
106-
npx hereby generate # Regenerate compiler sources and bundled assets
106+
npx hereby generate:go # Run the generators also exposed through go generate
107+
npx hereby generate # Regenerate all sources, assets, localization, and vendored files
107108
npx hereby format # Format Go, TypeScript, JSON, and YAML
108109
npx hereby check:format # Check formatting without changing files
109110
npx hereby tidy # Tidy both modules and synchronize go.work
110111
```
111112

113+
Generation is owned by `Herebyfile.mjs`; Go directives forward to the same
114+
`generate:*` tasks for compatibility. Use a subtask such as
115+
`npx hereby generate:diagnostics` to run one generator group, and pass `--force`
116+
to bypass incremental caches. `generate` includes every generator and fetches
117+
the pinned LSP model when its local cache is missing or stale. Use
118+
`generate:go` for the narrower scope of `go generate ./...` in the `tsc` module.
119+
112120
Package-specific commands:
113121

114122
```bash

0 commit comments

Comments
 (0)