test: use safe environment in pipe cleanup fixture

Author: KSemenenko

CodexSharpSDK.Tests/Unit/CliInstallationTests.cs

@@ -41,11 +41,10 @@ public sealed class CliInstallationTests
     private const string HangMarkerName = "hang";
     private const string PipeHolderMarkerName = "pipe-holder";
     private const string PipeHolderPidFileName = "pipe-holder.pid";
-    private const string SetsidPathEnvironmentName = "CODEX_TEST_SETSID_PATH";
-    private const string PipeHolderPidFileEnvironmentName = "CODEX_TEST_PIPE_HOLDER_PID_FILE";
     private const string SetsidCommandName = "setsid";
     private const string CleanupMessage = "CLI installation process or output cleanup could not be confirmed within its configured timeout.";
     private const string DetachedPipeHolderSkipReason = "The detached pipe-holder cleanup fixture requires Linux setsid.";
+    private const string SetsidRequiredMessage = "The detached pipe-holder cleanup fixture requires Linux setsid.";
     private const string OverflowMarkerName = "overflow";
     private const string PackagePlaceholder = "PACKAGE_NAME";
     private const string CliPlaceholder = "CLI_NAME";
@@ -88,9 +87,8 @@ public sealed class CliInstallationTests
         }
         if (fs.existsSync(path.join(__dirname, 'pipe-holder'))) {
             const { spawnSync } = require('node:child_process');
-            const shellCommand = '"$1" /bin/sh -c \'echo $$ > "$1"; exec /bin/sleep 60\' holder "$2" &';
-            spawnSync('/bin/sh', ['-c', shellCommand, 'fixture', process.env.CODEX_TEST_SETSID_PATH,
-                process.env.CODEX_TEST_PIPE_HOLDER_PID_FILE], { stdio: 'inherit' });
+            const shellCommand = `setsid /bin/sh -c 'echo $$ > ${shellQuote(path.join(__dirname, 'pipe-holder.pid'))}; exec /bin/sleep 60' holder &`;
+            spawnSync('/bin/sh', ['-c', shellCommand], { stdio: 'inherit' });
         }
         if (fs.existsSync(path.join(__dirname, 'overflow'))) {
             process.stdout.write('x'.repeat(8192));
@@ -256,8 +254,9 @@ public async Task CancellationWithDetachedPipeHolderSurfacesUnconfirmedCleanup()
             await File.WriteAllTextAsync(Path.Combine(fixture.NpmRoot, BinDirectoryName, PipeHolderMarkerName), string.Empty);
             var environment = fixture.Options.EnvironmentVariables.ToDictionary(
                 static pair => pair.Key, static pair => pair.Value, StringComparer.OrdinalIgnoreCase);
-            environment[SetsidPathEnvironmentName] = FindExecutablePath(SetsidCommandName);
-            environment[PipeHolderPidFileEnvironmentName] = holderPidFile;
+            var setsidPath = FindExecutablePath(SetsidCommandName);
+            environment[PathName] = string.Join(Path.PathSeparator, environment[PathName],
+                Path.GetDirectoryName(setsidPath)!);
             var options = fixture.Options with
             {
                 EnvironmentVariables = environment,
@@ -372,7 +371,7 @@ private static string FindExecutablePath(string executableName)
         var path = Environment.GetEnvironmentVariable(PathName) ?? string.Empty;
         var executable = path.Split(Path.PathSeparator, StringSplitOptions.RemoveEmptyEntries)
             .Select(directory => Path.Combine(directory, executableName)).FirstOrDefault(File.Exists);
-        return Path.GetFullPath(executable ?? throw new InvalidOperationException(NodeRequiredMessage));
+        return Path.GetFullPath(executable ?? throw new InvalidOperationException(SetsidRequiredMessage));
     }
 
     private static async Task WaitForFileAsync(string path, CancellationToken cancellationToken)