Repository navigation
Is VS Code v1.110.0 a necessary requirement? #1801
|
Question for you @randy3k: Throughout the work on 3.0.0, I must confess that I hadn't really noticed that the extension requires VS Code 1.110 or later. Unfortunately, this is now blocking me at work. We run OpenVSCode Server (not my preferred choice, but a bigger engineering challenge than I'm able to fight rn), and the newest version available to us is 1.103.1. Changing platforms isn't a realistic option in the short term, so I'm stuck on vscode-R 2.8.x :'-( AFAICT, this requirement came in with the session watcher rewrite in 4e1ca8b (#1684). I couldn't find a stated reason for the bump in the commit, the PR or the changelog. At the same time, I don't think that vscode-R 3.0.0+ actually uses any API newer than 1.75? I asked Claude to investigate and it agreed, pointing out that Was 1.110 chosen for a specific reason (a runtime behavior, a webview or terminal feature, or similar), or was it simply the current release at the time? If it's the latter, could we entertain a PR that lowers the minimum (for example to I'm happy to test 3.x on 1.103.1 and report back. |
Replies: 6 comments 4 replies
|
I don't recall why it was upgraded to be honest, please test downgrading it. I am sure more users will have the same question. |
|
I went through 3.0.1 to back up your reading. I couldn't find anything that needs more than 1.75, so 1.103.1 should be fine.
The bump itself is just To test on OpenVSCode Server 1.103.1 without waiting for a release:
If that holds up, a PR that lowers |
|
I checked the runtime dependencies and ran compatibility checks on VS Code 1.82.0. My recommendation is Two constraints are missing from the type-definition argument:
With the manifest constraints lowered, these checks passed on an isolated VS Code 1.82.0 on macOS:
I found no requirement for 1.110. These were targeted compatibility checks, not a complete regression run. Lowering both extensions to OpenVSCode Server 1.103.1 exceeds both existing dependency requirements, so lowering just the R extension’s manifest should allow testing there. That specific server environment still needs the attach/session, plot and help checks suggested above. |
|
Update to my earlier compatibility finding: PR #1831 upgrades the client to With only the manifest temporarily lowered, the upgraded extension passed TCP and stdio checks for completion, signature help, multiple-range formatting, diagnostics after edits, and shutdown on VS Code 1.91.0 / bundled Node 20.9.0, with R The published-package evidence and test details are in this PR comment. |
|
Follow-up with full-suite results: I recommend VS Code 1.94.0 ( On macOS arm64, 1.94.0 passed all 391 extension tests and both separate installer tests twice, including a final run with normal timeouts, no bail, no retries, no test changes and no skips. It uses bundled Node 20.16.0; the actual host-runtime launch test also passed. The other current checks passed, including 116 Node tests and 1,246 sess R assertions, and the source plus dependency declarations type-check against the actual 1.94 API. I tested every published VS Code release from the language client's 1.91.0 floor through 1.93.1. Each failed the full run at the Interactive test that waits for the stopped-session notebook notice after VS Code desktop 1.103.1 also passed all 393 VS Code tests, so the results support lowering the current 1.110.0 manifest requirement. OpenVSCode Server 1.103.1 exceeds both the recommended 1.94.0 baseline and R Syntax's declared 1.90.0 minimum. These runs were on macOS desktop; the actual OpenVSCode Server environment and a 1.94.0 Linux/Windows matrix still need validation. The manifest remains 1.110.0 in the upgrade PR; 1.94.0 is the recommendation from this investigation. Detailed version-by-version evidence. |
#1832 sets VS Code 1.94.0 (engines.vscode: "^1.94.0") as the minimum required vscode version.