Repository navigation
Preserve row order in prepend! with row iterators - #372
Merged
Merged
Conversation
The generic fallback built the result with `foldl(pushfirst!, rows)`, which put each new row at the front, so rows came out in reverse order. Instead, collect the rows into an empty `similar(s, 0)` with `append!` and prepend that column by column. This keeps the same element conversion as `push!`. Fixes #371 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
aplavin
approved these changes
Nov 11, 2026
Member
|
Looks like a clear bug fix, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #371.
If
rowscan't be added column by column,prepend!(s::StructVector, rows)falls back tofoldl(pushfirst!, rows; init = s). That puts each row at the front, so multiple rows come out in reverse order:The fallback now collects the rows into
similar(s, 0)withappend!(same element conversion aspush!) and prepends that column by column.append!itself is unchanged; it is just written out instead of being generated by the@evalloop shared withprepend!.The existing tests only prepended one row. I added multi-row cases for
NamedTupleand struct eltypes, a generator with element conversion, and an empty iterator. The new tests fail without the fix.🤖 Generated with Claude Code